Skip to content

improvements(memory_leaks): fix some memory leaks#342

Closed
Milerius wants to merge 4 commits intodevfrom
address_book_f
Closed

improvements(memory_leaks): fix some memory leaks#342
Milerius wants to merge 4 commits intodevfrom
address_book_f

Conversation

@Milerius
Copy link
Copy Markdown

@Milerius Milerius commented Jul 7, 2020

No description provided.

Milerius added 2 commits July 7, 2020 13:59
Signed-off-by: romanszterg <rmscastle@gmail.com>
Signed-off-by: romanszterg <rmscastle@gmail.com>
@Milerius Milerius marked this pull request as draft July 7, 2020 12:34
Milerius added 2 commits July 7, 2020 14:55
Signed-off-by: romanszterg <rmscastle@gmail.com>
Signed-off-by: romanszterg <rmscastle@gmail.com>
@Milerius Milerius closed this Jul 8, 2020
@Milerius Milerius deleted the address_book_f branch November 8, 2020 05:51
CharlVS added a commit that referenced this pull request Mar 27, 2026
Includes merged PR #342: RPC method hint for ambiguous KDF error parsing.
CharlVS added a commit that referenced this pull request Mar 27, 2026
…ning & UI redesign (#3465)

* feat(wallet): balance confirmation and withdraw flow updates

- Add CoinDetailsBalanceConfirmationController to confirm balance before showing amounts

- Extend withdraw form BLoC/state/events and coin details UI integration

- Improve coins repo/state USD conversion; update rewards and transaction views

- Add unit tests for balance confirmation and coins USD conversion

* fix: harden withdraw preview and balance confirmation

* chore: update sdk submodule pointer

* feat(wallet): redesign withdraw preview and success receipt UI

Refactor the withdraw confirmation screen into card-based sections
(summary, destination, TRON details) with responsive layouts, status
banners for expiration/refresh state, and a dedicated success receipt
replacing the reused TransactionDetails widget.

* fix(wallet): address PR review feedback on withdraw BLoC and balance widget

Use the live bloc state instead of the stale requestState snapshot when
emitting the Trezor confirmation flag in _generatePreview, preventing
isSending/isPreviewRefreshing from being reset mid-request.

Add didUpdateWidget to _BalanceState so the confirmation controller and
balance stream are torn down and re-bound when the parent supplies a
different coin without remounting the widget.

* fix(wallet): hoist Trezor confirmation flag into caller emissions

Move isAwaitingTrezorConfirmation into the callers' own "in progress"
emits (from requestState.copyWith) instead of emitting from the live
bloc state getter inside _generatePreview. This keeps all emissions
consistent with the explicit requestState snapshot pattern and makes
_generatePreview a pure function with no side effects.

* feat(wallet): add coin details section shortcut chips

Add transactions and addresses chips to the coin details header so users can jump directly to those sections without scanning the full page.

* fix(wallet): decouple coin details shortcut scrolling

Keep section scroll keys in the coin details state and pass semantic callbacks to child widgets so the shortcut chips depend on actions rather than scroll implementation details.

* fix(wallet): guard stale withdraw preview state merges

Preserve unrelated async updates while discarding preview results and errors once the effective withdraw request changes.

* test(wallet): expand coin details coverage across test layers

Add comprehensive coin-details unit/BLoC and widget coverage, plus integration scenarios and aggregate test wiring, so regressions in withdraw, transaction details, rewards, and faucet/address flows are caught earlier.

* fix(wallet): retry failed coin-details balance bootstrap

Schedule bounded startup retries when bootstrap fetch fails so coin-details balance confirmation does not remain stuck unconfirmed when the stream is quiet.

* chore(sdk): roll submodule to komodo-defi-sdk-flutter dev (b8555f1)

Includes merged PR #342: RPC method hint for ambiguous KDF error parsing.

* refactor(errors): centralize KDF user-facing messages in kdf_error_display

Add formatKdfUserFacingError and extractKdfTechnicalDetails (MmRpc,
GeneralErrorResponse, SdkError, activation wrappers). Use across withdraw,
coin addresses, transaction history, bridge/taker fee and preimage paths,
profit/loss and portfolio growth failures, and ARRR activation emit errors.
Drop redundant English prefixes where the underlying error is already
specific. Update withdraw_form_bloc tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant